Skip to content

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented Mar 20, 2025

Scripts enabling CI for benchmarking has gotten pretty big and complicated: #17545

Most of this code were developed by the UR team, and thus it no longer makes sense to ask dpcpp-devops-reviewers for PR approvals. This PR updates CODEOWNERS to ask llvm-reviewers-benchmarking for benchmarking scripts instead.

Note: The current path here puts /devops/scripts/benchmarks under llvm-reviewers-benchmarking: This path currently does not exist, but is chosen on purpose in anticipation for #17545.

The folder /devops/scripts/benchmarking will be removed in the future as a part of the effort to unify SYCL and UR benchmarking CI infrastructure; See #17229

@ianayl ianayl marked this pull request as ready for review March 20, 2025 01:48
@ianayl ianayl requested a review from a team as a code owner March 20, 2025 01:48
@uditagarwal97 uditagarwal97 requested a review from a team March 20, 2025 02:05
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @intel/llvm-reviewers-benchmarking approval first.

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uditagarwal97 uditagarwal97 merged commit 02593fa into intel:sycl Mar 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants